Skip to content

jindo: fix master and worker ports of jindo runtime #4247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 1 commit into from
Aug 6, 2024
Merged

jindo: fix master and worker ports of jindo runtime #4247

fluid-e2e-bot merged 1 commit into from
Aug 6, 2024

Conversation

@lx1036
Copy link
Contributor

@lx1036 lx1036 commented Aug 4, 2024

Ⅰ. Describe what this PR does

fix the issue: when jindocache/jindofsx runtime use container network, it can't use default DEFAULT_MASTER_RPC_PORT=8101 and DEFAULT_WORKER_RPC_PORT=6101.

Ⅱ. Does this pull request fix one issue?

NONE

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

when use JindoRuntime with networkmode: ContainerNetwork like:

apiVersion: data.fluid.io/v1alpha1
kind: JindoRuntime
metadata:
  name: liuxiang-fluid-jindocache-demo1
  namespace: fluid-system
spec:
  networkmode: ContainerNetwork
  replicas: 1
  tieredstore:
    levels:
      - mediumtype: SSD
        path: /mnt/liuxiang-fluid-jindocache-demo1
        quota: 10Gi
        high: "0.9"
        low: "0.7"

check the master/worker rpc port at configmap liuxiang-fluid-jindocache-demo1-jindocache-values is not default DEFAULT_MASTER_RPC_PORT=8101 and DEFAULT_WORKER_RPC_PORT=6101, otherwise is like:

master:
  ports:
    rpc: 18364

worker:
  ports:
    rpc: 19971

Ⅴ. Special notes for reviews

@lx1036
jindo: fix master and worker ports of jindo runtime
4239993 
Signed-off-by: LiuXiang <lx1036@126.com>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Aug 4, 2024

Hi @lx1036. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
100.0% Duplication on New Code

See analysis details on SonarCloud

@lx1036
Copy link
Contributor Author

lx1036 commented Aug 4, 2024

/assign @cheyang

TrafalgarZZZ
TrafalgarZZZ reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for fixing this! LGTM.
/lgtm

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Aug 6, 2024
@TrafalgarZZZ
Copy link
Member

TrafalgarZZZ commented Aug 6, 2024

/test fluid-e2e

cheyang
cheyang approved these changes Aug 6, 2024
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit bdbf03d into fluid-cloudnative:master Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrafalgarZZZ TrafalgarZZZ TrafalgarZZZ left review comments

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

@TrafalgarZZZ TrafalgarZZZ

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lx1036 @TrafalgarZZZ @cheyang