Skip to content

Fix security issue introduced in vineyard samples #4096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cheyang merged 1 commit into from
May 13, 2024
Merged

Fix security issue introduced in vineyard samples #4096

cheyang merged 1 commit into from
May 13, 2024

Conversation

@dashanji
Copy link
Contributor

@dashanji dashanji commented May 13, 2024

Ⅰ. Describe what this PR does

  • Fix 'Service account tokens should not be mounted in pods'.
  • Fix 'numpy.random.Generator should be preferred to numpy.random.RandomState'.

Ⅱ. Does this pull request fix one issue?

Fix #4082

@dashanji
* Fix 'Service account tokens should not be mounted in pods'.
e47f333 
* Fix 'numpy.random.Generator should be preferred to numpy.random.RandomState'.

Signed-off-by: Ye Cao <caoye.cao@alibaba-inc.com>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented May 13, 2024

Hi @dashanji. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
11.7% Duplication on New Code

See analysis details on SonarCloud

cheyang
cheyang approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label May 13, 2024
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit 37715c7 into fluid-cloudnative:master May 13, 2024
@dashanji dashanji deleted the fix-security-issues branch May 13, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cheyang cheyang cheyang approved these changes

Assignees

@cheyang cheyang

Labels

approved lgtm needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Service account tokens should not be mounted in pods

2 participants

@dashanji @cheyang