Skip to content

Conversation

@frankleaf
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: frankleaf <frank.wt@alibaba-inc.com>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
19.8% Duplication on New Code

See analysis details on SonarCloud

@codecov
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7221cf3) 64.29% compared to head (d2dbb59) 64.29%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3662   +/-   ##
=======================================
  Coverage   64.29%   64.29%           
=======================================
  Files         443      443           
  Lines       26767    26767           
=======================================
  Hits        17210    17210           
  Misses       7542     7542           
  Partials     2015     2015           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheyang cheyang requested a review from TrafalgarZZZ December 22, 2023 10:57
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Dec 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants