bugfix: clean up orphaned thinruntime resources #3393
Conversation
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Signed-off-by: trafalgarzzz <trafalgarz@outlook.com>
Codecov Report
@@ Coverage Diff @@
## master #3393 +/- ##
==========================================
- Coverage 64.40% 64.40% -0.01%
==========================================
Files 441 441
Lines 25978 25993 +15
==========================================
+ Hits 16732 16740 +8
- Misses 7268 7272 +4
- Partials 1978 1981 +3
|
|
Kudos, SonarCloud Quality Gate passed!
|
pkg/ddc/thin/shutdown.go
Outdated
| if err != nil { | ||
| return | ||
| } | ||
| return |
There was a problem hiding this comment.
Could you make the logic clear to understand?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Since #3272 , Fluid now uses
configmapsas the defaultHELM_DRIVERin Fluid controllers. However, this may lead to several upgrading issues like orphaned resources.This PR checks and deletes these orphaned resources in a best-effort way.
Ⅱ. Does this pull request fix one issue?
fixes #XXXX
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews