Skip to content

Conversation

@yangjun289519474
Copy link
Contributor

Ⅰ. Describe what this PR does

remove init container and sessmgr in efc-master yaml

Ⅱ. Does this pull request fix one issue?

fixes #3215

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Signed-off-by: zhanyi <hanson.yj@alibaba-inc.com>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented May 8, 2023

Hi @yangjun289519474. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #3216 (9fd26bd) into master (085b23e) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 9fd26bd differs from pull request most recent head 15cca94. Consider uploading reports for the commit 15cca94 to get more accurate results

@@            Coverage Diff             @@
##           master    #3216      +/-   ##
==========================================
- Coverage   65.53%   65.50%   -0.04%     
==========================================
  Files         396      397       +1     
  Lines       23077    23085       +8     
==========================================
- Hits        15124    15122       -2     
- Misses       6173     6182       +9     
- Partials     1780     1781       +1     
Impacted Files Coverage Δ
pkg/utils/kubelet/node_auth_client.go 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURES]:remove init-container and sessmgr-container from efc-master yaml

3 participants