Skip to content

Conversation

@fengshunli
Copy link
Member

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

app: csi-nodeplugin-fluid
spec:
serviceAccount: fluid-csi
serviceAccountName: fluid-csi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't update the released version. thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

app: csi-nodeplugin-fluid
spec:
serviceAccount: fluid-csi
serviceAccountName: fluid-csi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't update the released version. thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: fengshunli <1171313930@qq.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #2705 (6b2fc29) into master (73f1384) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 6b2fc29 differs from pull request most recent head b304dcd. Consider uploading reports for the commit b304dcd to get more accurate results

@@           Coverage Diff           @@
##           master    #2705   +/-   ##
=======================================
  Coverage   67.55%   67.56%           
=======================================
  Files         381      381           
  Lines       21968    21968           
=======================================
+ Hits        14840    14842    +2     
+ Misses       5381     5380    -1     
+ Partials     1747     1746    -1     
Impacted Files Coverage Δ
pkg/webhook/certificate_builder.go 84.09% <0.00%> (+4.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cheyang
Copy link
Collaborator

cheyang commented Mar 8, 2023

/lgtm
/approve

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants