Reverted changes to AssertionScope to maintain binary compatibility #977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note: I decided not to change |
jnyrup
approved these changes
Nov 20, 2018
Member
jnyrup
left a comment
There was a problem hiding this comment.
I tried yesterday to find projects on that depend on FA and looking at ~20-30 projects that looked like they could be extension libraries, none of them used Then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #925, some of the methods of
AssertionScopewere changed to return anIAssertionScopeinstead of the full class. However, this causes binary compatibility issues for libraries extending FluentAssertions. If such a library depended on a version between 5.0 and 5.5, upgrading to 5.5 would cause missing method exception. I've reverted those changes by exposing theIAssertionScopeinterface as explicit interface implementations.This should fix fluentassertions/fluentassertions.json#27