Skip to content

Comparing an object graph against IEnumerable works now as expected #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Nov 6, 2018
Merged

Comparing an object graph against IEnumerable works now as expected #911

dennisdoomen merged 1 commit into from
Nov 6, 2018

Conversation

@dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Sep 9, 2018

Added two overloads for Should().BeEquivalentTo that take an IEnumerable and treats those internally as IEnumerable<object>.

Fixes #881

@dennisdoomen dennisdoomen requested a review from jnyrup September 9, 2018 17:33
jnyrup
jnyrup reviewed Sep 9, 2018
View reviewed changes
@dennisdoomen dennisdoomen changed the title Comparing an object graph against IEnumerable works now as expected [WIP] Comparing an object graph against IEnumerable works now as expected Sep 11, 2018
@dennisdoomen dennisdoomen force-pushed the Fix881 branch 2 times, most recently from 179fe62 to 93a1972 Compare September 17, 2018 19:48
@dennisdoomen dennisdoomen mentioned this pull request Sep 18, 2018
Closed
@dennisdoomen dennisdoomen force-pushed the Fix881 branch 2 times, most recently from 13ef3a0 to 7ab0797 Compare September 19, 2018 19:34
@dennisdoomen
Copy link
Member Author

dennisdoomen commented Sep 20, 2018

I'll probably extract this into two PRs. One to fix the above mentioned bug and one to fix #918.

@dennisdoomen dennisdoomen mentioned this pull request Sep 27, 2018
Merged
@dennisdoomen dennisdoomen force-pushed the Fix881 branch 2 times, most recently from f30e014 to f853559 Compare October 19, 2018 14:05
@dennisdoomen dennisdoomen changed the title [WIP] Comparing an object graph against IEnumerable works now as expected Comparing an object graph against IEnumerable works now as expected Oct 20, 2018
@dennisdoomen dennisdoomen requested a review from jnyrup October 20, 2018 07:36
@dennisdoomen dennisdoomen added this to the 5.5.0 milestone Oct 20, 2018
jnyrup
jnyrup approved these changes Oct 21, 2018
View reviewed changes
jnyrup
jnyrup approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a feeling that changing this, would require more new tests, as I expected this to break some special crafted tests.

@dennisdoomen dennisdoomen merged commit b3b0245 into fluentassertions:master Nov 6, 2018
@dennisdoomen dennisdoomen deleted the Fix881 branch November 6, 2018 03:27
@jnyrup jnyrup mentioned this pull request Nov 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dennisdoomen @jnyrup