JSON assertions did not properly handle floats, doubles and unsigned … #3105
+170
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc73057 to
fcb1c0d
Compare
Pull Request Test Coverage Report for Build 18187186552Details
💛 - Coveralls |
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
jnyrup
requested changes
Sep 29, 2025
fcb1c0d to
965afe7
Compare
jnyrup
reviewed
Sep 30, 2025
965afe7 to
bf23e22
Compare
jnyrup
approved these changes
Oct 1, 2025
Member
jnyrup
left a comment
There was a problem hiding this comment.
Just a few small int32 -> numeric value corrections
bf23e22 to
cc443c0
Compare
cc443c0 to
3ffeed2
Compare
This was referenced Oct 2, 2025
This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in JSON assertions where the library wasn't properly handling certain numeric types during comparisons. The core issue was that the JSON conversion logic only checked for
intanddoublevalues, but missed other important numeric types like unsigned integers (uint,ulong), signed long integers (), and floats (float).longThe fix adds support for these missing numeric types by extending the conversion step to handle
uint, ,ulong, andfloatvalues. Additionally, it introduces a newIsNumeric()helper method that properly identifies all numeric JSON values by checking for ,ulong, ordoubletypes.long``longThanks to @jnyrup for the discovery.