Skip to content

Conversation

@dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Jul 20, 2025

Mostly as a way to dogfood PackageGuard on codebases with lots of different target frameworks and dependencies.

@dennisdoomen dennisdoomen added the building Building and Infrastructure of Fluent Assertions label Jul 20, 2025
@dennisdoomen dennisdoomen requested a review from Copilot July 20, 2025 07:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates PackageGuard into the build pipeline to perform package scanning and license validation. The change adds PackageGuard as a dependency scanning tool that validates package licenses against an allowlist configuration.

  • Adds PackageGuard tool as a package dependency and configures it in the build system
  • Creates a new ScanPackages target that runs before the Pack target to validate packages
  • Configures allowed licenses and packages through a JSON configuration file

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Build/_build.csproj Adds PackageGuard as a package download dependency
Build/Build.cs Implements ScanPackages target with GitHub API key parameter and tool configuration
.packageguard/config.json Defines allowed licenses and packages for PackageGuard validation
.nuke/build.schema.json Updates build schema to include new ScanPackages target and GitHubApiKey parameter
.github/workflows/build.yml Provides GitHub token as GitHubApiKey environment variable for CI

@coveralls
Copy link

Pull Request Test Coverage Report for Build 16397565687

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.298%

Totals Coverage Status
Change from base Build 16273047735: 0.0%
Covered Lines: 12546
Relevant Lines: 12748

💛 - Coveralls

@dennisdoomen dennisdoomen merged commit 29f6c06 into fluentassertions:main Jul 20, 2025
6 of 7 checks passed
@dennisdoomen dennisdoomen deleted the add-package-guard branch July 20, 2025 08:01
This was referenced Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants