Revisit the .editorconfig rules #3063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
026be7d to
8755893
Compare
Pull Request Test Coverage Report for Build 15954300159Details
💛 - Coveralls |
jnyrup
reviewed
Jun 24, 2025
Src/FluentAssertions/Collections/GenericDictionaryAssertions.cs
Outdated
Show resolved
Hide resolved
bb204da to
83fda36
Compare
Member
Author
|
@jnyrup I didn't make any changes other than rework on your comments, but I tried to split the modifications in a bunch of commits for clarity. |
83fda36 to
fbc5579
Compare
jnyrup
reviewed
Jun 27, 2025
Member
jnyrup
left a comment
There was a problem hiding this comment.
Good changes!
I often look in analyzer suggestions and it's now flooded with suggestions that are currently disabled.
Could we keep those disabled if we don't care about them?
AV1551
AV1706
AV2305
SA1615
SA1623
Src/FluentAssertions/Collections/GenericDictionaryAssertions.cs
Outdated
Show resolved
Hide resolved
bb204da to
cb7f318
Compare
jnyrup
approved these changes
Jun 29, 2025
This was referenced Jul 22, 2025
This was referenced Dec 31, 2025
This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by dennisdoomen/dotnet-library-starter-kit#31, I decided to revisit the
.editorconfigand use it in FA as well. This triggered a bunch of improvements and fine-tuning.Can be reviewed commit by commit.