Fix a formatting exception when {} is used as a dictionary key. #3029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
0cf2157 to
6089cb3
Compare
Pull Request Test Coverage Report for Build 13458568200Details
💛 - Coveralls |
jnyrup
approved these changes
Feb 21, 2025
Tests/FluentAssertions.Specs/Execution/AssertionChainSpecs.MessageFormating.cs
Outdated
Show resolved
Hide resolved
6089cb3 to
0aa1aeb
Compare
This was referenced Jul 21, 2025
This was referenced Dec 31, 2025
This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially in
BeEquivalentTocalls we often pass the path from the root of the graph to the position in the graph that is being compared as a string into theFailWithcalls. Since it's (apparently) possible that dictionary keys contain{and/or}, this caused a crash in theMessageBuilderwhile building the final failure message. We couldn't use normalstring.Formatplaceholders like{0},{1}and such because that caused theFormatterclass to enclose strings with quotes. We solved that by introducing a special internal extension methodAsNonFormattablethat wraps the object to be formatted in such a way that theFormatterwill not try to apply any formatting.This solves #2704