Skip to content

Redesign Configuration, Services and AssertionOptions #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Jan 4, 2025
Merged

Redesign Configuration, Services and AssertionOptions #2901

dennisdoomen merged 1 commit into from
Jan 4, 2025

Conversation

@dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Dec 20, 2024 •
edited
Loading

Addresses #2291

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Dec 20, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen dennisdoomen force-pushed the 2291-combine-configurations branch 2 times, most recently from dab7b54 to 2d7342d Compare December 22, 2024 09:12
@dennisdoomen dennisdoomen changed the title Combine Configuration, Services and AssertionOptions Redesign Configuration, Services and AssertionOptions Dec 22, 2024
@dennisdoomen dennisdoomen force-pushed the 2291-combine-configurations branch 2 times, most recently from 4afc13c to 8510445 Compare December 22, 2024 12:35
jnyrup
jnyrup reviewed Dec 22, 2024
View reviewed changes
@dennisdoomen dennisdoomen self-assigned this Dec 24, 2024
@dennisdoomen dennisdoomen force-pushed the 2291-combine-configurations branch 2 times, most recently from fbf3395 to 1e77b2d Compare December 26, 2024 11:25
@coveralls
Copy link

coveralls commented Dec 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12611449685

Details

  • 95 of 95 (100.0%) changed or added relevant lines in 24 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 97.4%
Files with Coverage Reduction New Missed Lines %
Src/FluentAssertions/Formatting/AttributeBasedFormatter.cs 1 91.38%
Totals Coverage Status
Change from base Build 12610160657: 0.003%
Covered Lines: 12276
Relevant Lines: 12460
💛 - Coveralls

@dennisdoomen dennisdoomen force-pushed the 2291-combine-configurations branch 5 times, most recently from cf8517f to 6e5cea5 Compare January 3, 2025 20:33
@dennisdoomen dennisdoomen requested a review from jnyrup January 3, 2025 20:33
@dennisdoomen dennisdoomen marked this pull request as ready for review January 3, 2025 20:33
@dennisdoomen dennisdoomen force-pushed the 2291-combine-configurations branch 3 times, most recently from 01decde to 4ecef9c Compare January 3, 2025 21:26
jnyrup
jnyrup reviewed Jan 4, 2025
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice restructuring 💪
It's much easier to reason about global vs local options/configuration 🧠
No more fiddling with which TFMs have System.Configuration available 😌
One dependency less 🚀
(Two if we say goodbye to Chill 😉)

@dennisdoomen dennisdoomen force-pushed the 2291-combine-configurations branch 2 times, most recently from 910298b to 34f9a8c Compare January 4, 2025 13:29
@dennisdoomen dennisdoomen requested a review from jnyrup January 4, 2025 13:29
jnyrup
jnyrup reviewed Jan 4, 2025
View reviewed changes
@dennisdoomen dennisdoomen force-pushed the 2291-combine-configurations branch from 34f9a8c to a1aa537 Compare January 4, 2025 14:39
@dennisdoomen dennisdoomen requested a review from jnyrup January 4, 2025 14:40
This was referenced Dec 31, 2025
Closed
Closed
Open
Merged
Open
Open
Open
Open
Closed
This was referenced Jan 7, 2026
Closed
Closed
Open
Merged
Closed
Open
Closed
Closed
Merged
Open
Open
Open
Closed
Open
Open
Open
Open
This was referenced Jan 14, 2026
Open
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

+1 more reviewer

@lg2de lg2de lg2de left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dennisdoomen dennisdoomen

Labels

breaking change enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dennisdoomen @coveralls @jnyrup @lg2de