Skip to content

Downgrade ConfigurationManager from 6.0.1 to 6.0.0 #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 1 commit into from
Nov 30, 2024
Merged

Downgrade ConfigurationManager from 6.0.1 to 6.0.0 #2855

jnyrup merged 1 commit into from
Nov 30, 2024

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Nov 29, 2024 •
edited
Loading

#2673 bumped from 4.4.0 -> 6.0.1, but 6.0.0 should be enough.
As a testing-only library I think we should strive for picking lower versions of dependencies to avoid that tests use a newer package than what is used in production due to included FA.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@jnyrup
Downgrade ConfigurationManager from 6.0.1 to 6.0.0
62b635e 
fluentassertions#2673 bumped from 4.4.0 -> 6.0.1, but 6.0.0 should be enough.
As a testing nuget we should pick the lowest possible version of a package to avoid that tests use a newer package than what is used in production.
@github-actions
Copy link

github-actions bot commented Nov 29, 2024

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12087488378

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.398%
Totals Coverage Status
Change from base Build 12055576910: 0.0%
Covered Lines: 12374
Relevant Lines: 12563
💛 - Coveralls

@jnyrup jnyrup requested a review from dennisdoomen November 29, 2024 16:00
@jnyrup
Copy link
Member Author

jnyrup commented Nov 29, 2024

System.Threading.Tasks.Extensions (STTE) still seems beneficial to upgrade to 4.5.4.
#2673 has great explanations, here are some more.

Currently our net47 TFM uses the net45 variant of STTE even though a netstandard2.0 exists, as net45 is closer to net47.

STTE 4.5.4 added a net461 TFM, which our net47 TFM will use since that's even closer.

I compared the output of building the net47 tests with STTE 4.5.0 and 4.5.4
With STTE bin/ now contains different versions of STTE and System.Runtime.CompilerServices.Unsafe.

image

Comparing the packages using NuGet Package Explorer the net47 dll now also has a lot fewer metadata references (I assume this is better, but honestly don't know)
image

@dennisdoomen
Copy link
Member

dennisdoomen commented Nov 30, 2024

I don't really get that either, but if you look in STTE 4.5.0 and 4.5.3, you'll see that they contain the same (albeit a newer version) DLLs, and only as a PCL.

image

@jnyrup jnyrup merged commit 0ac7a58 into fluentassertions:develop Nov 30, 2024
8 checks passed
@jnyrup jnyrup deleted the configuration_manager_downgrade branch November 30, 2024 12:04
@jnyrup jnyrup mentioned this pull request Nov 30, 2024
Merged
7 tasks
@jnyrup jnyrup added the dependencies Pull requests that update a dependency file label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jnyrup @coveralls @dennisdoomen