Skip to content

Fixed a regression in which CompleteWithinAsync treated a canceled task as an exception #2853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Feb 11, 2025
Merged

Fixed a regression in which CompleteWithinAsync treated a canceled task as an exception #2853

dennisdoomen merged 1 commit into from
Feb 11, 2025

Conversation

@dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Nov 28, 2024

Closes #2833

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@coveralls
Copy link

coveralls commented Nov 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 13248870431

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.066%
Totals Coverage Status
Change from base Build 13091505027: 0.0%
Covered Lines: 13018
Relevant Lines: 13276
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen dennisdoomen requested a review from jnyrup November 28, 2024 18:55
jnyrup
jnyrup reviewed Nov 29, 2024
View reviewed changes
@dennisdoomen dennisdoomen requested review from jnyrup and removed request for jnyrup December 15, 2024 12:47
@jnyrup jnyrup mentioned this pull request Dec 19, 2024
Merged
7 tasks
@jnyrup jnyrup changed the base branch from main to support-7.0 January 19, 2025 20:07
@jnyrup jnyrup changed the base branch from support-7.0 to main January 19, 2025 20:08
@jnyrup jnyrup changed the base branch from main to support-7.0 January 19, 2025 20:15
@jnyrup jnyrup force-pushed the fix-canceled-task branch 2 times, most recently from 5c823fa to 6e030f1 Compare January 19, 2025 20:18
@dennisdoomen dennisdoomen deleted the fix-canceled-task branch January 20, 2025 19:33
@dennisdoomen dennisdoomen restored the fix-canceled-task branch February 1, 2025 16:58
@dennisdoomen dennisdoomen reopened this Feb 1, 2025
@jnyrup jnyrup added this to the 7.2.0 milestone Feb 10, 2025
@IT-VBFK IT-VBFK mentioned this pull request Feb 10, 2025
Closed
@dennisdoomen dennisdoomen merged commit 3dd8243 into fluentassertions:support-7.0 Feb 11, 2025
5 checks passed
This was referenced Dec 30, 2025
Merged
Closed
Closed
Open
Merged
Open
Open
Open
Merged
Closed
Closed
This was referenced Jan 7, 2026
Open
Closed
Closed
Open
Closed
Closed
Merged
Closed
Closed
Merged
Open
Open
Open
Closed
Open
This was referenced Jan 14, 2026
Open
Open
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

@jnyrup jnyrup

Labels

bug

Projects

None yet

Milestone

7.2.0

Development

Successfully merging this pull request may close these issues.

CompleteWithinAsync fails for canceled Tasks

3 participants

@dennisdoomen @coveralls @jnyrup