Skip to content

Add a bunch of assertions on XElement and XDocument #2690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 10 commits into from
Oct 30, 2024
Merged

Add a bunch of assertions on XElement and XDocument #2690

dennisdoomen merged 10 commits into from
Oct 30, 2024

Conversation

@ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Jul 8, 2024 •
edited
Loading

  • HaveElementWithValue(string expectedName, string expectedValue) - The element exists and has a particular value
    • XElementAssertions
    • XDocumentAssertions
  • NotHaveElement(string unexpectedName) - The element does not exist
    • XElementAssertions
    • XDocumentAssertions
  • NotHaveElementWithValue(string unexpectedName, string unexpectedValue) - The element either does not exist or doesn't have the particular value
    • XElementAssertions
    • XDocumentAssertions
  • HaveAttribute(string expectedName) - The attribute exists and can have any value
  • HaveAttributeWithValue(string expectedName, string expectedValue) - The attribute exists and has a particular value
  • NotHaveAttribute(string unexpectedName) - The attribute does not exist
  • NotHaveAttributeWithValue(string unexpectedName, string unexpectedValue) - The attribute either does not exist or doesn't have the particular value

Closes: #2589
Supersedes: #2588

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Jul 8, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Jul 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11588463853

Details

  • 203 of 203 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 97.656%
Totals Coverage Status
Change from base Build 11574987093: 0.03%
Covered Lines: 12387
Relevant Lines: 12560
💛 - Coveralls

@ITaluone ITaluone changed the title WIP: Add XelementAssertion for absent elements and/or values WIP: Add XElementAssertion for absent elements and/or values Jul 9, 2024
@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch 2 times, most recently from 0d7e599 to f275e00 Compare July 9, 2024 09:20
@ITaluone ITaluone changed the title WIP: Add XElementAssertion for absent elements and/or values WIP: Add a bunch of XElementAssertions Jul 9, 2024
@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch 2 times, most recently from 8b3f661 to 5f7fd15 Compare July 9, 2024 13:04
@ITaluone ITaluone changed the title WIP: Add a bunch of XElementAssertions WIP: Add a bunch of assertions on XElement and XDocument Jul 9, 2024
@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch from 04bbd13 to 0937a60 Compare July 9, 2024 14:07
@ITaluone ITaluone marked this pull request as ready for review July 9, 2024 14:17
@ITaluone ITaluone changed the title WIP: Add a bunch of assertions on XElement and XDocument Add a bunch of assertions on XElement and XDocument Jul 10, 2024
dennisdoomen
dennisdoomen reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a great start. Thanks for that.

I left an initial set of comments for some of the files, but which also need to be applied on the rest. Please re-request the review when you feel the rest also addresses the comments.

@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch from 4885402 to 2a2691b Compare August 8, 2024 06:50
@ITaluone ITaluone requested a review from dennisdoomen August 8, 2024 06:52
@ITaluone
Copy link
Contributor Author

ITaluone commented Aug 8, 2024

I revised several changed code and I think I got everything 🤞

@ITaluone
Copy link
Contributor Author

ITaluone commented Aug 8, 2024 •
edited
Loading

Is the qodana key expired?

2024/08/08 06:52:01 License request: token was declined by Qodana Cloud server

@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch 3 times, most recently from 3147c5e to 35dd5d7 Compare August 8, 2024 08:55
@dennisdoomen
Copy link
Member

dennisdoomen commented Aug 9, 2024

Is the qodana key expired?

Yes, and I already have a nice license, but somehow it's not working yet. Working with JetBrains to resolve this ASAP.

@IT-VBFK IT-VBFK mentioned this pull request Aug 11, 2024
Closed
@dennisdoomen
Copy link
Member

dennisdoomen commented Aug 14, 2024

Is the qodana key expired?

Fixed

@dennisdoomen dennisdoomen requested a review from jnyrup August 14, 2024 06:05
@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch from 35dd5d7 to b6578b0 Compare August 14, 2024 06:41
@ITaluone
Copy link
Contributor Author

ITaluone commented Aug 14, 2024

(rebased onto current develop)

@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch 3 times, most recently from f351abf to 1694909 Compare August 22, 2024 13:33
@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch from 1694909 to 283e565 Compare August 27, 2024 06:04
@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch from 283e565 to bfaeb7f Compare October 29, 2024 09:25
ITaluone
ITaluone commented Oct 29, 2024
View reviewed changes
@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch from bfaeb7f to 0b2d2ca Compare October 29, 2024 21:49
@github-actions
Copy link

github-actions bot commented Oct 29, 2024 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch from 0b2d2ca to 74ad235 Compare October 30, 2024 06:13
@ITaluone ITaluone force-pushed the feat/xdocument-element-absent branch from 74ad235 to abcbaa0 Compare October 30, 2024 07:00
@IT-VBFK
Copy link
Contributor

IT-VBFK commented Oct 30, 2024 •
edited
Loading

@dennisdoomen Is everything alright with Jonas, or is he that much occupied? 🤔

@dennisdoomen dennisdoomen merged commit d091986 into fluentassertions:develop Oct 30, 2024
@ITaluone ITaluone deleted the feat/xdocument-element-absent branch October 31, 2024 06:23
@jnyrup
Copy link
Member

jnyrup commented Nov 4, 2024

@dennisdoomen Is everything alright with Jonas, or is he that much occupied? 🤔

@IT-VBFK
Thanks for checking in with me ❤️
I'm hopelessly behind on FA stuff - much more active on restaurant, bar and theater visits.

@jnyrup jnyrup mentioned this pull request Jan 6, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup Awaiting requested review from jnyrup

+1 more reviewer

@IT-VBFK IT-VBFK IT-VBFK left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add feature to check if an XElement or XAttribute is absent within the XDocument

5 participants

@ITaluone @coveralls @dennisdoomen @IT-VBFK @jnyrup