Filter the list of events returned by RaisePropertyChangeFor #2677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 9584175842Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 9584308904Details
💛 - Coveralls |
dennisdoomen
requested changes
Jul 3, 2024
Member
dennisdoomen
left a comment
There was a problem hiding this comment.
Nice pull request. Lots of tricky situations to consider.
8d875b5 to
2bb5a3c
Compare
Pull Request Test Coverage Report for Build 10380338666Details
💛 - Coveralls |
Member
|
@arocheleau just to be clear, if you have addressed the comments, please mark them as resolved and re-request a review. Then I'll know when to look at the rework. |
jnyrup
approved these changes
Aug 10, 2024
| subject.RaiseEventWithSenderAndPropertyName(nameof(EventRaisingClass.SomeOtherProperty)); | ||
|
|
||
| // Act | ||
| monitor.Should().RaisePropertyChangeFor(x => x.SomeProperty).Count().Should().Be(2); |
Member
There was a problem hiding this comment.
Suggested change
| monitor.Should().RaisePropertyChangeFor(x => x.SomeProperty).Count().Should().Be(2); | |
| monitor.Should().RaisePropertyChangeFor(x => x.SomeProperty).Should().HaveCount(2); |
Member
|
@arocheleau Let me know if you want to do something with the suggestions from @jnyrup so we know when to merge this PR. |
b315f16 to
926081a
Compare
926081a to
12ad8cc
Compare
Contributor
Author
|
@dennisdoomen I have applied the suggestions from @jnyrup |
jnyrup
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
RaisePropertyChangeForonEventAssertions<T>now returns a filtered list of events related to the property given as parameter. TheNotRaisePropertyChangeForfunction has been revised as well to match the behavior ofRaisePropertyChangeForespecially when the parameter provided isnull.This fixes #393.
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome