Add support for `Satisfy` on `ReferenceTypeAssertions` #2597

siewers · 2024-02-29T19:59:05Z

Added support for Satisfy on ReferenceTypeAssertions allowing to use element inspectors as an alternative to using predicates on Match.

Example:

var myDto = new Dto { Name = "Some Name" };

myDto.Should().Satisfy<Dto>(dto => dto.Name.Should().Be("Some Name"));

Fixed #2516

IMPORTANT

If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
The code complies with the Coding Guidelines for C#.
The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
- Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

github-actions · 2024-02-29T20:04:09Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Tests/FluentAssertions.Specs/Primitives/ReferenceTypeAssertionsSpecs.Satisfy.cs

ITaluone · 2024-03-01T06:03:30Z

Missing release notes?

siewers · 2024-03-01T08:33:09Z

I didn't add it to the release notes yet as I'm unsure what version this will be in.

@dennisdoomen I can see that we're at Alpha 3 now, but the release notes only contain Alpha 1. I've added the changes to the current section of the releases.md, but I think something might be wrong. Can you let me know if I need to change something?

ITaluone · 2024-03-01T09:33:38Z

I didn't add it to the release notes yet as I'm unsure what version this will be in.

I think while on develop for the next version it doesn't really matter

siewers · 2024-03-01T09:41:12Z

@ITaluone Alright, I added it the the most recent section. I guess it will be aligned when the final release goes out, however, it might be a bit confusing for people using the Alpha versions to see the release notes not reflecting the latest version.

siewers · 2024-03-01T10:08:01Z

@dennisdoomen @ITaluone I believe I've addressed all comments now.

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs

docs/_pages/basicassertions.md

docs/_pages/releases.md

coveralls · 2024-03-11T07:50:34Z

Pull Request Test Coverage Report for Build 9436657769

Details

22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.01%) to 97.577%

Totals
Change from base Build 9428450907:	0.01%
Covered Lines:	12078
Relevant Lines:	12261

💛 - Coveralls

dennisdoomen · 2024-03-11T08:50:06Z

I believe I've addressed all comments now.

Apparently not.

ITaluone · 2024-03-12T09:42:49Z

@siewers Could you rebase to current develop and force push again?

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs

dennisdoomen · 2024-03-17T20:14:51Z

Did you close it on purpose?

siewers · 2024-03-17T20:17:11Z

Wow, no, I didn't... I don't know what happened.

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs

siewers · 2024-05-12T09:21:45Z

@dennisdoomen I see you approved this PR, but it's blocked by a couple of checks. Is there anything further on my part I need to take care of?

IT-VBFK · 2024-05-12T12:45:35Z

Rebase to current develop and force push

github-actions · 2024-05-14T17:23:23Z

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

ITaluone · 2024-05-16T15:22:03Z

@siewers To fix the current problems rebase again :)

siewers · 2024-05-23T07:50:35Z

I've rebased, and all checks are passing. Can we merge this?

dennisdoomen · 2024-05-23T10:07:10Z

I've rebased, and all checks are passing. Can we merge this?

Waiting for a review from @jnyrup

…spectors

Co-authored-by: Dennis Doomen <dennis.doomen@avivasolutions.nl>

siewers mentioned this pull request Feb 29, 2024

Allow Should().Satisfy() on objects and not only collections #2516

Closed

ITaluone reviewed Mar 1, 2024

View reviewed changes

Tests/FluentAssertions.Specs/Primitives/ReferenceTypeAssertionsSpecs.Satisfy.cs Outdated Show resolved Hide resolved

dennisdoomen reviewed Mar 2, 2024

View reviewed changes

IT-VBFK reviewed Mar 12, 2024

View reviewed changes

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs Show resolved Hide resolved

siewers closed this Mar 17, 2024

dennisdoomen mentioned this pull request Mar 17, 2024

Allow nested AssertionScopes to chain their context #2607

Merged

7 tasks

siewers reopened this Mar 17, 2024

jnyrup reviewed Mar 24, 2024

View reviewed changes

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs Outdated Show resolved Hide resolved

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs Outdated Show resolved Hide resolved

jnyrup mentioned this pull request Apr 10, 2024

[API Proposal]: Allow to assert RegEx matched groups #2625

Open

jnyrup reviewed Apr 10, 2024

View reviewed changes

Src/FluentAssertions/Primitives/ReferenceTypeAssertions.cs Show resolved Hide resolved

dennisdoomen approved these changes May 10, 2024

View reviewed changes

jnyrup changed the title ~~Add support for Satisfy on ReferenceTypeAssertions~~ Add support for Satisfy on ReferenceTypeAssertions May 27, 2024

Add support for Satisfy on reference type assertions using element in…

1406c08

…spectors

siewers and others added 13 commits June 9, 2024 11:17

Combine Act and Assert in tests that should not throw

d3051da

Reorganize and add additional test for complex object not throwing

a037484

Update release notes

3e1da18

Update tests to follow guidelines

a2517cd

Add tests asserting derived types

e4bbf68

Use date extensions in assertions

156b23f

Rephrase release notes

34c28d9

Co-authored-by: Dennis Doomen <dennis.doomen@avivasolutions.nl>

Rephrase XML documentation

e9fd5e4

Fix documentation layout

c9e4828

Approve API

50816d3

Check subject for null

830e589

Ensure preconditions are met

ba8c369

Do not throw NRE if Subject is null inside type compatibility check

2a536ac

jnyrup approved these changes Jun 9, 2024

View reviewed changes

Update tests

3e30035

dennisdoomen merged commit 418a327 into fluentassertions:develop Jun 10, 2024

ITaluone mentioned this pull request Sep 11, 2024

[API Proposal]: ObjectAssertions Class Should Allow Only One Generic Type #2755

Closed

dennisdoomen added the enhancement label Nov 3, 2024

Add support for Satisfy on ReferenceTypeAssertions #2597

Add support for Satisfy on ReferenceTypeAssertions #2597

Uh oh!

Conversation

siewers commented Feb 29, 2024 • edited by jnyrup Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

IMPORTANT

Uh oh!

github-actions bot commented Feb 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana for .NET

Uh oh!

Uh oh!

ITaluone commented Mar 1, 2024

Uh oh!

siewers commented Mar 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ITaluone commented Mar 1, 2024

Uh oh!

siewers commented Mar 1, 2024

Uh oh!

siewers commented Mar 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Mar 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 9436657769

Details

💛 - Coveralls

Uh oh!

dennisdoomen commented Mar 11, 2024

Uh oh!

ITaluone commented Mar 12, 2024

Uh oh!

Uh oh!

dennisdoomen commented Mar 17, 2024

Uh oh!

siewers commented Mar 17, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

siewers commented May 12, 2024

Uh oh!

IT-VBFK commented May 12, 2024

Uh oh!

github-actions bot commented May 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Qodana for .NET

Uh oh!

ITaluone commented May 16, 2024

Uh oh!

siewers commented May 23, 2024

Uh oh!

dennisdoomen commented May 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Add support for `Satisfy` on `ReferenceTypeAssertions` #2597

Add support for `Satisfy` on `ReferenceTypeAssertions` #2597

siewers commented Feb 29, 2024 •

edited by jnyrup

Loading

github-actions bot commented Feb 29, 2024 •

edited

Loading

siewers commented Mar 1, 2024 •

edited

Loading

coveralls commented Mar 11, 2024 •

edited

Loading

github-actions bot commented May 14, 2024 •

edited

Loading