Add support for NUnit4 #2483
Add support for NUnit4 #2483
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.2.8
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 7016904197Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
|
Since it seems to contain some breaking changes, supporting both Nunit 3 and 4 makes sense to me. |
| Exception exception = act.Should().Throw<Exception>().Which; | ||
| exception.GetType() | ||
| .FullName.Should() | ||
| .ContainEquivalentOf("NUnit.Framework.AssertionException"); |
There was a problem hiding this comment.
🤔 Are you sure this is the right one? I was also expecting a different version of the NUnitTestFramework type. Or are the exception types the same?
There was a problem hiding this comment.
Our current NUnitTestFramework also matches NUnit4, so no changes are needed on our side.
NUnit.Framework.AssertionException
There was a problem hiding this comment.
The Test adapter also remained unchanged, according to the release notes:
|
NUnit4 needs to added here fluentassertions/Build/Build.cs Lines 275 to 281 in 29e9699 |
|
The failing build is because NUnit4.Specs needs to be build in debug for the |
Add FrameworkSpecs for NUnit4 and mention support in documentation and package information.
Fixes #2482
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome