Skip to content

Allow IEqualityComparer in string (Not)BeEquivalentTo assertion #2372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vbreuss wants to merge 8 commits into from
Closed

Allow IEqualityComparer in string (Not)BeEquivalentTo assertion #2372

vbreuss wants to merge 8 commits into from

Conversation

@vbreuss
Copy link
Contributor

@vbreuss vbreuss commented Oct 9, 2023 •
edited
Loading

Add an overload for StringAssertions.BeEquivalentTo and StringAssertions.NotBeEquivalentTo that accepts a IEqualityComparer<string>.

Details are discussed in #2364.
Fixes #2339.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Oct 9, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.6
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Oct 9, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6586651679

  • 34 of 34 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 97.399%
Totals Coverage Status
Change from base Build 6586600692: 0.002%
Covered Lines: 11665
Relevant Lines: 11856
💛 - Coveralls

@vbreuss vbreuss marked this pull request as ready for review October 9, 2023 07:32
dennisdoomen
dennisdoomen requested changes Oct 14, 2023
View reviewed changes
@vbreuss vbreuss mentioned this pull request Oct 14, 2023
Closed
@github-actions
Copy link

github-actions bot commented Oct 14, 2023 •
edited
Loading

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen dennisdoomen changed the title Allow IEqualityComparer in string BeEquivalentTo assertion Allow IEqualityComparer in string (Not)BeEquivalentTo assertion Oct 14, 2023
dennisdoomen
dennisdoomen reviewed Oct 14, 2023
View reviewed changes
@dennisdoomen dennisdoomen requested a review from jnyrup October 14, 2023 14:23
@vbreuss vbreuss mentioned this pull request Oct 29, 2023
Merged
7 tasks
@vbreuss
Copy link
Contributor Author

vbreuss commented Oct 31, 2023

The changes will be implemented with #2413

@vbreuss vbreuss closed this Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup Awaiting requested review from jnyrup

+1 more reviewer

@IT-VBFK IT-VBFK IT-VBFK left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow IEqualityComparer in string equality assertion

4 participants

@vbreuss @coveralls @dennisdoomen @IT-VBFK