Skip to content

Add extensions for OccurrenceConstraint that reads more fluently #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 10 commits into from
Jan 1, 2023
Merged

Add extensions for OccurrenceConstraint that reads more fluently #2047

dennisdoomen merged 10 commits into from
Jan 1, 2023

Conversation

@IT-VBFK
Copy link
Contributor

@IT-VBFK IT-VBFK commented Nov 28, 2022 •
edited
Loading

Authored by @siewers, committed by @IT-VBFK

Closes #2045

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@dennisdoomen
Copy link
Member

dennisdoomen commented Nov 28, 2022

Is this still work in progress?

@IT-VBFK IT-VBFK force-pushed the issue-2045 branch 2 times, most recently from 784056a to 0c77b25 Compare November 28, 2022 19:38
@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Nov 28, 2022

Not really, why?

@dennisdoomen
Copy link
Member

dennisdoomen commented Nov 28, 2022

Just checking whether I can start reviewing it.

@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Nov 28, 2022

Oh.. yes :)
sorry

@coveralls
Copy link

coveralls commented Nov 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3794573532

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 96.94%
Totals Coverage Status
Change from base Build 3789210470: 0.9%
Covered Lines: 12476
Relevant Lines: 12719
💛 - Coveralls

@jnyrup
Copy link
Member

jnyrup commented Nov 28, 2022

Please, can we agree on the API in #2045 first. 🙏

I see I really need to get this written, but the label "api-suggestion" is supposed to mean "this is a suggestion for a modification to the public api, but it is not yeat ready for implementation".
"api-approved" is "this is ready for implementation".

@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Nov 28, 2022

Please, can we agree on the API in #2045 first. 🙏

Then.. I will make this a WIP..

@IT-VBFK IT-VBFK marked this pull request as draft November 28, 2022 19:46
@IT-VBFK IT-VBFK force-pushed the issue-2045 branch 2 times, most recently from 7a51917 to 95e4eff Compare December 28, 2022 14:22
@IT-VBFK IT-VBFK marked this pull request as ready for review December 28, 2022 15:30
@jnyrup jnyrup added the feature label Dec 29, 2022
jnyrup
jnyrup reviewed Dec 30, 2022
View reviewed changes
@IT-VBFK IT-VBFK requested a review from jnyrup December 30, 2022 10:34
jnyrup
jnyrup reviewed Dec 30, 2022
View reviewed changes
@jnyrup jnyrup requested a review from dennisdoomen December 30, 2022 11:09
@IT-VBFK
Copy link
Contributor Author

IT-VBFK commented Dec 30, 2022

Just a note: Please make sure to add the line "Authored by @siewers, committed by @IT-VBFK" in the commit message, to give @siewers the credit for the change, because it is actually his work :)

@IT-VBFK IT-VBFK changed the title Add extensions for occurrence constraint that reads more fluently Add extensions for OccurrenceConstraint that reads more fluently Dec 30, 2022
dennisdoomen
dennisdoomen requested changes Jan 1, 2023
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment •
edited by jnyrup
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update strings.md to show the new way.

This was referenced Sep 8, 2025
Closed
Open
This was referenced Sep 15, 2025
Closed
Closed
Closed
This was referenced Sep 25, 2025
Closed
Closed
Closed
Closed
This was referenced Oct 3, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 13, 2025
Closed
This was referenced Oct 20, 2025
Closed
Closed
Open
Open
This was referenced Oct 27, 2025
Closed
Closed
This was referenced Nov 10, 2025
Closed
Closed
This was referenced Nov 24, 2025
Closed
Open
This was referenced Dec 1, 2025
Closed
Closed
Merged
Closed
This was referenced Dec 22, 2025
Open
Closed
This was referenced Jan 11, 2026
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Include extension methods for OccurrenceConstraint that reads more fluently

4 participants

@IT-VBFK @dennisdoomen @coveralls @jnyrup