BeEmpty fix #1692
Merged
BeEmpty fix #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eneration iterates over an infinite collection and causes an OverflowException.
…rtion failure message.
jnyrup
approved these changes
Sep 27, 2021
Member
jnyrup
left a comment
There was a problem hiding this comment.
Thanks for contributing this.
Can we ask you to add a line to the release notes?
Tests/FluentAssertions.Specs/Collections/CollectionAssertionSpecs.BeEmpty.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Sure no problem. I just wanted to see if you approve this fix before adding to the release notes. |
Contributor
Author
|
OK. All done. |
dennisdoomen
approved these changes
Sep 27, 2021
Member
|
@FabianNitsche You had the PR in draft mode. |
Contributor
Author
|
No nothing to add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test and fixes issue #1691 by using the Count property of ICollection instead of directly iterating over the enumerable by Count().