Hide protected member to avoid confusion for folks upgrading to v6 #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
approved these changes
Aug 11, 2021
Member
|
I would have expected api approval tests to fail? |
In v6, there's no Should().Throw() that handles async code because you need to use Should().ThrowAsync() for that. However, while dogfooding, I discovered that existing calls to ThrowAsync() will raise a "Cannot access a protected member here". By renaming, it'll be clearer that a different method must be used.
b0257d2 to
a486c23
Compare
Member
Author
Good point. The build did not even trigger. And on my local machine, the tests didn't fail. Anyway, after re-running everything, it did flag them as breaking changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v6, there's no
Should().Throw()that handlesasynccode because you need to useShould().ThrowAsync()for that. However, while dogfooding, I discovered that existing calls toThrow()will raise aCannot access a protected member here. By renaming the protected members ofDelegateAssertionsBase, it'll be clearer that a different method must be used.