Support covariant and inherited property exclusion and inclusion in BeEquivalentTo #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1bbce09 to
26a0b8f
Compare
This also broke a test that was relying on some internal behavior in earlier versions of the framework.
Simply calling GetProperties on a hierarchy that includes covariant or "new" properties will also include the hidden properties. The new implementation traverses the class hierarchy and will only return the fields and properties that are really visible from a certain type.
jnyrup
reviewed
Aug 4, 2021
Tests/FluentAssertions.Specs/Equivalency/BasicEquivalencySpecs.cs
Outdated
Show resolved
Hide resolved
jnyrup
approved these changes
Aug 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluding()orIncluding()covariant properties in aBeEquivalentTocall didn't work. To reproduce this, I had to include .NET 5 to the frameworks the unit test project targets. Also, covariant properties behave completely different from normal properties. In fact, from a Reflection point of view, it looks like a covariant property is a completely different property, a bit likenewproperties. See also this SO thread.Then while looking at #1363, I discovered another problem. Simply calling
GetPropertieson a hierarchy that includes covariant or "new" properties will also include the hidden properties, causing weird side-effects later on. The new implementation traverses the class hierarchy and will only return the fields and properties that are really visible from a certain type.Fixes #1562 and #1363