Faking time because timing executions can be flaky on AppVeyor #1620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On AppVeyor builds, we have observed some flakiness where timing a simple Thread.Sleep(200) can result in up to 400 milliseconds of execution time. For those specific unit tests, we have decided to replace Stopwatch usage with a fake timer abstraction.
Member
|
Wohoo! |
This was referenced Jul 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On AppVeyor builds, we have observed some flakiness where timing a simple
Thread.Sleep(200)can result in up to 400 milliseconds of execution time. For those specific unit tests, we have decided to replaceStopwatchusage with a fake timer abstraction for those specific cases. For the other execution timing tests, I've decided to keep using the realStopwatch.Fixes #1085