Harden DataSet types against a continuing AssertionScope #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
May 26, 2021
| .FailWith("Expected {context:DataSet} to contain {0}, but found {1} table(s)", expectation.Tables.Count, subject.Tables.Count); | ||
|
|
||
| if (dataConfig is not null) | ||
| if (success) |
Member
There was a problem hiding this comment.
🔧 Maybe jumping out of the method when success is false may make this method better readable.
Member
Author
There was a problem hiding this comment.
As in an early return?
I would be happy to do that instead, I only avoided it for your sake.
Member
There was a problem hiding this comment.
In this case, it would make total sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 44efddb
ShouldExcludeColumnthrew an NRE whensubjectColumnwas null.This is now null guarded to avoid checking whether a non-existing column should be excluded.
A few lines below
subjectColumnandexpectationColumnare compared and potential null values are taken into account.In 03fffcd
DataRowCollectionEquivalencyStep.OnHandledid checksubject.Count == expectation.Countbefore invokingMatchRowsByIndexAndComparewhich threw anIndexOutOfRangeException, but it didn't take into account being on a continuingAssertionScope.I also added some more
AssertionScopeguards to theDataSetrelated classes in 03fffcd.This fixes #1530