Skip to content

Add Formatter for IDictionary #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 1 commit into from
May 25, 2021
Merged

Add Formatter for IDictionary #1577

jnyrup merged 1 commit into from
May 25, 2021

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented May 24, 2021

Copied and adjusted the EnumerableValueFormatter to handle instances of IDictionary.

With the addition of DictionaryValueFormatter the output of the included When_formatting_a_dictionary_it_should_format_keys_and_values changes from

{[FluentAssertions.Specs.Formatting.FormatterSpecs+MyKey, FluentAssertions.Specs.Formatting.FormatterSpecs+MyValue]}

to

{[
    FluentAssertions.Specs.Formatting.FormatterSpecs+MyKey
    {
        KeyProp = 13
    }] = 
    FluentAssertions.Specs.Formatting.FormatterSpecs+MyValue
    {
        ValueProp = 37
    }
}

Part of fixing #1527

@jnyrup jnyrup merged commit 501cf35 into fluentassertions:develop May 25, 2021
@jnyrup jnyrup deleted the Issue1527 branch May 25, 2021 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnyrup @dennisdoomen