Add WithResult to TaskCompletionSourceAssertion #1478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
Jan 21, 2021
Member
dennisdoomen
left a comment
There was a problem hiding this comment.
Please also update the release notes
jnyrup
reviewed
Jan 21, 2021
78dc921 to
8683dea
Compare
lg2de
commented
Jan 31, 2021
jnyrup
reviewed
Jan 31, 2021
8683dea to
455ee20
Compare
jnyrup
approved these changes
Feb 9, 2021
Member
|
@lg2de can you please rebase the PR so we can merge it? |
455ee20 to
e066386
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While further development of tests using async assertions (async methods and TaskCompletionSource) I found that asserting the result is not as fluent as possible.
Therefore I provide new idea to assert the result.
If you agree I'll complete with