Improve XML assertion messages #1440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was triggered by reading #1353 that most XML assertion messages does not include variable name too.
So I've started reworking these assertions to
While reviewing the texts in the unit tests I found some messages which are misleading because the XmlValidator was following the subject instead of the expectation.
You may want to review the two commits separately.
I'll add changelog when the PR number is available...
Should these two commits result into two statements in the changelog?