Skip to content

Introduce new overload of Enumerating() (#1431) #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 3 commits into from
Nov 17, 2020
Merged

Introduce new overload of Enumerating() (#1431) #1433

jnyrup merged 3 commits into from
Nov 17, 2020

Conversation

@mu88
Copy link
Contributor

@mu88 mu88 commented Nov 17, 2020

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution adds a feature or fixes a bug, please update the release notes, which are published on the website.
  • If the contribution changes the public API the changes needs to be included by running AcceptApiChanges.ps1/AcceptApiChanges.sh.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@dennisdoomen dennisdoomen requested a review from jnyrup November 17, 2020 09:57
@mu88
Copy link
Contributor Author

mu88 commented Nov 17, 2020

Any ideas why the AppVeyor build is failing? I cannot reproduce this on my machine 🤔

jnyrup
jnyrup approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, looks good to me.

Can I ask you to make two additional changes:

  • Update docs\_pages\releases.md with a line about the added overloads
  • Add an example in docs\_pages\exceptions.md just below the func.Enumerating().Should().Throw<ArgumentException>(); example

mu88 and others added 2 commits November 17, 2020 11:33
@jnyrup jnyrup merged commit 2cca450 into fluentassertions:develop Nov 17, 2020
@jnyrup jnyrup linked an issue Nov 17, 2020 that may be closed by this pull request
Unexpected behavior with IEnumerable and exceptions #1431
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unexpected behavior with IEnumerable and exceptions

3 participants

@mu88 @dennisdoomen @jnyrup