Skip to content

Change AttributeBasedFormatter to allow custom formatter selection ba… #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 8 commits into from
Nov 4, 2020
Merged

Change AttributeBasedFormatter to allow custom formatter selection ba… #1418

jnyrup merged 8 commits into from
Nov 4, 2020

Conversation

@Serg046
Copy link
Contributor

@Serg046 Serg046 commented Oct 29, 2020 •
edited
Loading

…sed on the parent type

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution adds a feature or fixes a bug, please update the release notes, which are published on the website.
  • If the contribution changes the public API the changes needs to be included by running AcceptApiChanges.ps1/AcceptApiChanges.sh.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

Fixes #309

dennisdoomen
dennisdoomen reviewed Oct 30, 2020
View reviewed changes
jnyrup
jnyrup reviewed Oct 30, 2020
View reviewed changes
@dennisdoomen dennisdoomen requested a review from jnyrup October 31, 2020 19:08
jnyrup
jnyrup reviewed Nov 1, 2020
View reviewed changes
jnyrup
jnyrup approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dennisdoomen Are you fine with the API breakage?

@dennisdoomen
Copy link
Member

dennisdoomen commented Nov 4, 2020

Which breakage are you talking about?

@Serg046
Copy link
Contributor Author

Serg046 commented Nov 4, 2020 •
edited
Loading

AttributeBasedFormatter is public.
Since we are changing Formatter from array to dictionary anyway, I changed the member to be private.

@jnyrup
Copy link
Member

jnyrup commented Nov 4, 2020

@dennisdoomen

Which breakage are you talking about?

Removing Formatters from the public type AttributeBasedFormatter.
The property has been public since the class was introduced, but it seems more of an implementation detail.

@dennisdoomen
Copy link
Member

dennisdoomen commented Nov 4, 2020

I'm fine with that.

@jnyrup
Copy link
Member

jnyrup commented Nov 4, 2020

@Serg046 As a last thing, can I ask you to add a line to releases.md?

@Serg046 Serg046 requested a review from jnyrup November 4, 2020 19:00
@jnyrup jnyrup merged commit e2fd717 into fluentassertions:develop Nov 4, 2020
@jnyrup
Copy link
Member

jnyrup commented Nov 4, 2020

@Serg046 Thanks for another nice contribution and for going through the iterations it took to get to this result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup Awaiting requested review from jnyrup

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow custom formatters to "kick in" for more specific types

3 participants

@Serg046 @dennisdoomen @jnyrup