Skip to content

Make StringAssertions.StartWith and String.StartsWith consistent #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 2 commits into from
Oct 24, 2020
Merged

Make StringAssertions.StartWith and String.StartsWith consistent #1413

dennisdoomen merged 2 commits into from
Oct 24, 2020

Conversation

@Serg046
Copy link
Contributor

@Serg046 Serg046 commented Oct 24, 2020 •
edited
Loading

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution adds a feature or fixes a bug, please update the release notes, which are published on the website.
  • If the contribution changes the public API the changes needs to be included by running AcceptApiChanges.ps1/AcceptApiChanges.sh.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

@Serg046
Copy link
Contributor Author

Serg046 commented Oct 24, 2020

Linked issue is #1410.

dennisdoomen
dennisdoomen approved these changes Oct 24, 2020
View reviewed changes
@jnyrup jnyrup linked an issue Oct 24, 2020 that may be closed by this pull request
Inconsistency between StringAssertions.StartWith and String.StartsWith #1410
Closed
@dennisdoomen dennisdoomen merged commit 094ad35 into fluentassertions:develop Oct 24, 2020
@jnyrup
Copy link
Member

jnyrup commented Oct 25, 2020

@Serg046 Thanks for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inconsistency between StringAssertions.StartWith and String.StartsWith

3 participants

@Serg046 @jnyrup @dennisdoomen