Skip to content

Add NotBeEquivalentTo with config overload #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 1 commit into from
Oct 13, 2020
Merged

Add NotBeEquivalentTo with config overload #1408

jnyrup merged 1 commit into from
Oct 13, 2020

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Oct 12, 2020

This PR adds an overloads of CollectionAssertions.BeEquivalentTo that takes a config parameter.

Since #593 CollectionAssertions.BeEquivalentTo no longer used GetMissingItems.
https://github.com/fluentassertions/fluentassertions/pull/593/files?file-filters%5B%5D=#diff-4cf34d1b2865162998773f88349aecab.
The same removal should be done here, as GetMissingItems relies on Contains which checks for equality and not equivalence.

@jnyrup jnyrup force-pushed the NotBeEquivalentTo branch from 694562c to dcdb744 Compare October 12, 2020 19:12
dennisdoomen
dennisdoomen approved these changes Oct 13, 2020
View reviewed changes
@jnyrup jnyrup force-pushed the NotBeEquivalentTo branch from dcdb744 to 45e2473 Compare October 13, 2020 05:52
@jnyrup jnyrup merged commit 0973b3a into fluentassertions:develop Oct 13, 2020
@jnyrup jnyrup deleted the NotBeEquivalentTo branch October 13, 2020 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnyrup @dennisdoomen