Guard against negative values as precision arguments #1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a negative precision argument is provided this innocent looking test ``` double value = 1.5; value.Should().BeApproximately(value, -1); ``` fails with the slightly confusing failure message ``` Expected value to approximate 1.5 +/- -1.0, but 1.5 differed by 0.0. ```
dennisdoomen
approved these changes
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a negative
precisionargument is provided, this innocent looking testfails with the slightly confusing failure message
Instead explicitly guard against negative
precision.Note:
NumericAssertionsExtensions.BeCloseTofor integer values uses a unsigneddeltaparameter to guard against negative values.This fixes #1384