Make ObjectAssertions generic in TSubject #1371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
Aug 9, 2020
46f97c9 to
8558be9
Compare
Member
Author
|
@lg2de Can you think of why |
Contributor
|
I'm currently away from office, so I have no chance for detailed analysis. I've no explanation. There is no logical reason according to these changes. Maybe we should increase the timeouts. If it is a deadlock, the test will fail anyway. But we must ensure that the problem is not caused by accidental overload of the build machine. |
Member
Author
|
Ahh... It probably just needs to use a |
8558be9 to
c356268
Compare
Member
Author
|
I've rerun the CI-build successfully and tracked the flaky test in #1372 1372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a custom assertions class, deriving from
ObjectAssertions<TSubject, TAssertions>instead ofReferenceTypeAssertions<TSubject, TAssertions>gives you[Not]Beand[Not]BeEquivalentTofor free.