Add async support for Where method (#1352) #1362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
Jul 24, 2020
Member
dennisdoomen
left a comment
There was a problem hiding this comment.
Would you be willing to also update the release notes at https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md?
lg2de
reviewed
Jul 24, 2020
| return (await task).WithInnerException<TInnerException>(because, becauseArgs); | ||
| } | ||
|
|
||
| #pragma warning restore AV1755 |
Contributor
There was a problem hiding this comment.
Why restoring warning for the documentation?
Instead I would recommend to disable this warning for the whole file.
All these extension will not follow the rule because of the fluent api.
Contributor
Author
There was a problem hiding this comment.
Ouch, this should not be here. Should I amend or just add new commit?
Contributor
Author
|
@dennisdoomen Yep, but which release version should it be? |
Member
6 |
jnyrup
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1352