Add ForConstraint to AssertionScope to open up OccurenceConstraint for usage in custom assertion extensions #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…traint for usage in custom assertion extensions
dennisdoomen
reviewed
Jun 1, 2020
|
|
||
| Execute.Assertion | ||
| .ForCondition(occurrenceConstraint.Assert(actual)) | ||
| .ForOccurrences(occurrenceConstraint, actual) |
Member
There was a problem hiding this comment.
I think ForConstraint will work better, but I'm not 100% sure. I even ask Twitterverse for some guidance.
Contributor
Author
There was a problem hiding this comment.
I guess that guys in Twitter aren't actually getting the context for these concepts. IMHO ForConstraint will work just fine, it's correct in technical sense.
dennisdoomen
reviewed
Jun 1, 2020
febeb61 to
3baa7bc
Compare
dennisdoomen
reviewed
Jun 2, 2020
dennisdoomen
approved these changes
Jun 2, 2020
jnyrup
approved these changes
Jun 5, 2020
Member
jnyrup
left a comment
There was a problem hiding this comment.
LGTM.
I'm repeatedly amazed about how much FA users apparently extend the library.
It would be nice having a test that adds a custom OccurrenceConstraint to exemplify the purpose of ForConstraint for library consumer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves library extension interface as requested in #1281.
Some equivalent
ForConditionusages are replaced withForOccurrences(StringAssertions.ContainandStringAssertions.ContainEquivalentOf), and as methods containing them covered with unit test, I considerForOccurrencescovered enough as well.The existence of
{expectedOccurrences}placeholder is mentioned in documentation comment forForOccurrencesmethod. I don't think it should be inFailWithdoc comment as it would make it too large and hard to read.IMPORTANT
AcceptApiChanges.ps1/AcceptApiChanges.sh.