Improved the message when the PropertyChanged event was raised for the wrong property #1333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
788ccf6 to
794870d
Compare
jnyrup
reviewed
May 25, 2020
| var actualPropertyNames = recording | ||
| .SelectMany(@event => @event.Parameters.OfType<PropertyChangedEventArgs>()) | ||
| .Select(@args => @args.PropertyName) | ||
| .Distinct() |
Member
There was a problem hiding this comment.
Is there a tests that exercises the distinctiveness?
Member
There was a problem hiding this comment.
I don’t think changed test exercises the call to Distinct. Such a test would need to raise the same event twice and check that the failure message only contains the name of the event once.
| return recording.WithArgs<PropertyChangedEventArgs>(args => args.PropertyName == propertyName); | ||
| var actualPropertyNames = recording | ||
| .SelectMany(@event => @event.Parameters.OfType<PropertyChangedEventArgs>()) | ||
| .Select(@args => @args.PropertyName) |
Member
There was a problem hiding this comment.
Suggested change
| .Select(@args => @args.PropertyName) | |
| .Select(arg => arg.PropertyName) |
794870d to
b4ee584
Compare
jnyrup
approved these changes
May 25, 2020
jnyrup
approved these changes
May 25, 2020
b4ee584 to
9da570b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919