Add AllBe for string collections #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
requested changes
May 25, 2020
Member
dennisdoomen
left a comment
There was a problem hiding this comment.
Thanks for the PR.
The XML docs and test names are a bit weird. It provided two suggestions to help you get the gist.
Tests/FluentAssertions.Specs/Equivalency/CollectionEquivalencySpecs.cs
Outdated
Show resolved
Hide resolved
jnyrup
approved these changes
May 26, 2020
Member
jnyrup
left a comment
There was a problem hiding this comment.
Nice work 👍
Please add a line to docs\_pages\releases.md
It would also be nice with an example in docs\_pages\collections.md
It could be added right under stringCollection.Should().ContainMatch("* failed");
Contributor
Author
|
@dennisdoomen, @jnyrup thanks for the review! |
dennisdoomen
approved these changes
May 27, 2020
Member
|
Looks like you still need to accept the API changes using |
…ing-collections # Conflicts: # docs/_pages/releases.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements feature #1263.
IMPORTANT