Skip to content

Allows using an IEqualityComparer<T> with BeEquivalentTo #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Mar 30, 2020
Merged

Allows using an IEqualityComparer<T> with BeEquivalentTo #1284

dennisdoomen merged 1 commit into from
Mar 30, 2020

Conversation

@dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Mar 29, 2020 •
edited
Loading

Adds overloads to the Using method of BeEquivalentTo options parameter to allows using an implementation of IEqualityComparer<T> as an alternative to IEquivalencyStep.

Resolves #1236

@dennisdoomen dennisdoomen force-pushed the Feature/IEqualityComparer branch 2 times, most recently from 5d98982 to 81aa1d7 Compare March 29, 2020 15:27
jnyrup
jnyrup reviewed Mar 29, 2020
View reviewed changes
@dennisdoomen dennisdoomen force-pushed the Feature/IEqualityComparer branch 3 times, most recently from dcd1263 to 0b04d8a Compare March 29, 2020 17:33
@dennisdoomen dennisdoomen requested a review from jnyrup March 29, 2020 17:33
jnyrup
jnyrup reviewed Mar 29, 2020
View reviewed changes
@dennisdoomen dennisdoomen force-pushed the Feature/IEqualityComparer branch from 0b04d8a to f37fb98 Compare March 29, 2020 18:25
@dennisdoomen dennisdoomen requested a review from jnyrup March 29, 2020 18:37
@jnyrup
Copy link
Member

jnyrup commented Mar 29, 2020 •
edited
Loading

It would maybe be nice with a test hitting the UseRuntimeTypes case.

@dennisdoomen dennisdoomen force-pushed the Feature/IEqualityComparer branch from f37fb98 to 2f7de4e Compare March 30, 2020 15:55
@dennisdoomen
Copy link
Member Author

dennisdoomen commented Mar 30, 2020

It would maybe be nice with a test hitting the UseRuntimeTypes case.

Because you insist ;-)

@jnyrup
Copy link
Member

jnyrup commented Mar 30, 2020

Woohoo!

@dennisdoomen dennisdoomen merged commit c7ec7c6 into fluentassertions:develop Mar 30, 2020
@dennisdoomen dennisdoomen deleted the Feature/IEqualityComparer branch March 30, 2020 16:26
@cz-dev-ge cz-dev-ge mentioned this pull request May 26, 2021
Closed
@jnyrup jnyrup mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow using an IEqualityComparer in BeEquivalentTo

2 participants

@dennisdoomen @jnyrup