Added NotContainMatch method for string collections and unit tests to cover it #1246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
requested changes
Feb 6, 2020
Member
dennisdoomen
left a comment
There was a problem hiding this comment.
Please also include the change in https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md
jnyrup
requested changes
Feb 6, 2020
Member
jnyrup
left a comment
There was a problem hiding this comment.
Overall looks good 👍
I'd like some tests covering the Which part of the return value.
Contributor
Author
|
@dennisdoomen @jnyrup Thanks for the review, all issues should hopefully now be resolved. |
dennisdoomen
approved these changes
Feb 7, 2020
jnyrup
reviewed
Feb 8, 2020
jnyrup
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added NotContainMatch for string collections which does the opposite of ContainMatch. I recently had a need for NotContainMatch so decided to add it.