Skip to content

Remove obsoleted members #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 5 commits into from
Jan 11, 2020
Merged

Remove obsoleted members #1221

dennisdoomen merged 5 commits into from
Jan 11, 2020

Conversation

@jnyrup
Copy link
Member

@jnyrup jnyrup commented Jan 6, 2020

Remove members marked as Obsolete for removal in 6.0.

dennisdoomen
dennisdoomen approved these changes Jan 6, 2020
View reviewed changes
Copy link
Member

@dennisdoomen dennisdoomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure we include this in the release notes. Maybe we should start updating the releases.md as part of our PRs?

@jnyrup
Copy link
Member Author

jnyrup commented Jan 6, 2020

Good idea, I'll do that.
Would you prefer that I split out these changes into separate PRs, such that each line in the release notes refers to different PRs?

@dennisdoomen
Copy link
Member

dennisdoomen commented Jan 9, 2020

Would you prefer that I split out these changes into separate PRs, such that each line in the release notes refers to different PRs?

Meh. Just let them refer to the same PR.

@jnyrup jnyrup force-pushed the RemoveObsoleteMembers branch from 745536b to 19ced75 Compare January 11, 2020 11:19
@jnyrup jnyrup force-pushed the RemoveObsoleteMembers branch from 19ced75 to 0a290be Compare January 11, 2020 11:26
@jnyrup
Copy link
Member Author

jnyrup commented Jan 11, 2020

I've updated the release notes, let me know if you have any comments.

@dennisdoomen dennisdoomen merged commit 35f5d7f into fluentassertions:develop Jan 11, 2020
@jnyrup jnyrup deleted the RemoveObsoleteMembers branch January 11, 2020 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jnyrup @dennisdoomen