Add API approval tests #1217
Merged
Add API approval tests #1217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b53e7b to
19f1278
Compare
dennisdoomen
approved these changes
Jan 4, 2020
2570913 to
1d51870
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extra step to the test stage to verify that the public API does not change unnoticed.
The
approved.txtfiles contains a snapshot of the current public API for all supported target frameworks.From now on all public API changes will require updating the
approved.txtfiles.I intentionally added a API breaking change to verify that the CI build breaks as expected.
Will update the PR once the CI-build turns red as expected.
Fixes #1133