Add Have/NotHaveSameCount for Dictionaries #1178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
reviewed
Nov 7, 2019
| { | ||
| Guard.ThrowIfArgumentIsNull(otherCollection, nameof(otherCollection), "Cannot compare dictionary count against a <null> collection."); | ||
|
|
||
| if (ReferenceEquals(Subject, null)) |
Member
There was a problem hiding this comment.
The reason is null isn't used in CollectionAssertions.HaveSameCount is because TSubject is not constrained to reference types and is null can only be used on reference types.
Member
There was a problem hiding this comment.
SonarQube keeps telling me (in another project) to compare to default(T) ;-)
Contributor
Author
|
If there are no other concerns, what's the process for getting this merged? |
dennisdoomen
approved these changes
Nov 9, 2019
Member
|
@veleek Could I ask you to change the two |
Use `is null` instead of `ReferenceEquals(..., null)`.
jnyrup
approved these changes
Nov 11, 2019
Member
|
@veleek Thanks for the contribution! |
Member
Indeed. Another nice little gem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for
HaveSameCountandNotHaveSameCountfor dictionaries. This was almost directly cribbed from the existingCollectionAssertions(including test cases).Resolves #1176
IMPORTANT