Add StringCollectionAssertions::ContainMatch #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
Sep 15, 2019
jnyrup
reviewed
Sep 15, 2019
jnyrup
reviewed
Sep 15, 2019
jnyrup
reviewed
Sep 15, 2019
Contributor
Author
|
Any additional concerns or comments in order to wrap this up? @jnyrup @dennisdoomen |
Member
Not from me. @jnyrup has been thorough enough 😀 |
jnyrup
approved these changes
Sep 17, 2019
Member
|
Thanks @danielmpetrov for taking the time to implement this and the additional changes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #482
It's an old one, but better late than never, right?