Add StringAssertions::NotBeEquivalentTo #1134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
requested changes
Sep 9, 2019
Member
jnyrup
left a comment
There was a problem hiding this comment.
Thanks for taking up this task!
I've only got a few things before everything looks good to me.
If any of my comments are unclear, don't hesitate asking.
Contributor
Author
Thanks for the review. Since it's getting late now, I'll resolve these tomorrow and let you know. |
dennisdoomen
approved these changes
Sep 10, 2019
Member
dennisdoomen
left a comment
There was a problem hiding this comment.
Great PR. I have only one comment/concern.
jnyrup
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #997