Allow nesting equivalency checks in custom assertion rules #1033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnyrup
reviewed
Apr 25, 2019
| { | ||
| if (step.CanHandle(context, config) && step.Handle(context, parent, config)) | ||
| { | ||
| return true; |
| public bool CanHandle(IEquivalencyValidationContext context, IEquivalencyAssertionOptions config) | ||
| { | ||
| return !context.IsRoot; | ||
| return true; |
Member
There was a problem hiding this comment.
❓ I'm not sure what the implications of this change are?
Member
Author
There was a problem hiding this comment.
That's the real fix. I honestly don't know (or remember) why that condition existed in the first place.
| // Act | ||
| //----------------------------------------------------------------------------------------------------------- | ||
| Action act = () => subject.Should().BeEquivalentTo(expectation, options => options | ||
| .Using<ClassWithSomeFieldsAndProperties>(ctx => ctx.Subject.Should().BeEquivalentTo(ctx.Expectation, nestedOptions=> nestedOptions.Excluding(x => x.Property2))) |
Member
There was a problem hiding this comment.
🙃 Missing whitespace in nestedOptions=>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations of
IAssertionRule(including the usage ofUsing().WhenTypeIs()were never run for root objects.Fixes #1032