FluentAction for shorter syntax for exception assertions #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisdoomen
approved these changes
Mar 31, 2019
Src/FluentAssertions/FluentAction.cs
Outdated
| /// Contains static methods to help with exception assertions on actions. | ||
| /// </summary> | ||
| [DebuggerNonUserCode] | ||
| public static class FluentAction |
Member
There was a problem hiding this comment.
I think naming this class FluentActions would be better, since it is just a static container with static methods.
docs/_pages/documentation.md
Outdated
| act.Should().NotThrowAfter(2.Seconds(), 100.Milliseconds()); | ||
| ``` | ||
|
|
||
| If you prefer single-statement assertions, consider using the `FluentAction` static class, which has `Invoking`, `Awaiting`, and `Enumerating` methods: |
jnyrup
requested changes
Mar 31, 2019
Src/FluentAssertions/FluentAction.cs
Outdated
| public static class FluentAction | ||
| { | ||
| /// <summary> | ||
| /// Invokes the specified action so that you can chain it with ShouldThrow, etc. |
Member
There was a problem hiding this comment.
Should().Throw()?
ShouldThrow() is pre-5.0.0 notation.
| /// Invokes the specified action so that you can chain it with ShouldThrow, etc. | ||
| /// </summary> | ||
| [Pure] | ||
| public static Func<T> Invoking<T>(Func<T> func) => func; |
Member
There was a problem hiding this comment.
@dennisdoomen If we decide on the name Invoking for Fun<T> here, then #872 should also be named Invoking for consistency.
docs/_pages/documentation.md
Outdated
| If you prefer single-statement assertions, consider using the `FluentAction` static class, which has `Invoking`, `Awaiting`, and `Enumerating` methods: | ||
|
|
||
| ```csharp | ||
| FluentAction.Invoking(() => MyClass.Create(null)).Should().Throw<ArgumentNullException(); |
Member
There was a problem hiding this comment.
typo: Missing > after ArgumentNullException.
docs/_pages/documentation.md
Outdated
|
|
||
| ... | ||
|
|
||
| Invoking(() => MyClass.Create(null)).Should().Throw<ArgumentNullException(); |
Member
There was a problem hiding this comment.
typo: Missing > after ArgumentNullException.
Contributor
Author
|
I also forgot to add the unit tests to the shared project. 😬 Fixed: 7a647b3 |
jnyrup
approved these changes
Mar 31, 2019
Member
|
Thanks for the contribution @ejball. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1015.