I was looking into this and noticed a few things that may inform what direction to take.

First, I added a new assertion set for IReadOnlyDictionary, we can base it off the existing IDictionary variant and do some ToDictionary shenanigans in the construtor to leverage all the existing asserts. This works great, but it introduces an ambiguity that will break existing uses of the original assertions on Dictionary since it implements both the read-only and regular interfaces.

We could avoid that breaking change by adding a Should() specifically for Dictionary but it would still be breaking for anyone with their own types that do the same thing.

Second, we could change to base off IEnumerable<KeyValuePair<TKey,TValue>> as @dennisdoomen proposed. This is less error prone and should work (though I haven't tried it yet). The advantage would be that we could reuse the existing IEnumerable assertions for HaveCount, etc., however, the downside is that we'd probably have to do some magic for the ContainKeys and other such assertions (like trying to cast to dictionaries first, then doing it by hand if it isn't one).

Clearly, there are multiple directions to take here, but I felt it worth discussing first after my initial investigations. Thoughts? Suggestions?

IReadOnlyDictionary #357

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions