-
Notifications
You must be signed in to change notification settings - Fork 731
Closed
Milestone
Description
After release of V6 there are issues reported which cannot be (completely) realized before V7 because of breaking changes.
This issue lists all pending changes including link to related issue(s). It will be updated permanently.
- Make
ComparableAssertionsmore generic - draft - Remove
GreaterOrEqualTo(obsolete) methods replaced byGreaterThanOrEqualTo(Change names of "OrEqualTo" assertion methods #1673) - In
EquivalentValidatorreplace the lastIEquivalencyStepwith a hard-coded assertion to replace theNotImplementedException. See https://github.com/fluentassertions/fluentassertions/blob/master/Src/FluentAssertions/Equivalency/EquivalencyValidator.cs#L76 - Rename
RespectingRuntimeTypestoRespectingRuntimeTypePropertiesor something like that. See Exception thrown when comparing empty types using 'BeEquivalentTo' with 'RespectingRuntimeTypes' set #1830. Also, it can be confusing because we also haveIncludingAllRuntimePropertiesandIncludingAllDeclaredProperties - Check whether assertions on
AndWhichConstraintshould be executed withinAssertionScopeafter base assertion has failed. See discussion on Slack. - Refactor
AsyncFunctionAssertionsas "real" base class (preparation in Prepare constructors ofAsyncFunctionAssertionsto make them protected in V7 #1972). - Investigate if we can replace/aid
CallerIdentifierusing[CallerArgumentExpression].- sometimes it could also be useful to extract the variable name of the
expectedparameter. - this might also let us replace
Expression<>withFunc<> - investigate whether this works for .NET 4.8 as well
- sometimes it could also be useful to extract the variable name of the
- Consider renaming
AssertionScope.CurrenttoAssertionScope.ThreadInstance - Consider renaming
FailWithsince it does not always throw - Consider renaming
ExcludingNestedObjectsto something with recursive in it or deep vs shallow - Align terminology between "object graph comparison" in the docs vs "structural comparison" in the code.
- Consider renaming "expected" to "expectation" and "unexpected" to ?, to use nouns instead of adjectives
- Consider returning
AndWhichConstraintfromGenericCollectionAssertions.ContainItemsAssignableTo<T> - Consider making
EquivalencyValidatorand some other "internal" classesinternal
304NotModified